Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quadlet - prefer "param val" over "param=val" to allow env expansion #24128

Merged

Conversation

ygalblum
Copy link
Contributor

@ygalblum ygalblum commented Oct 1, 2024

When possible use a generic function to add strings and booleans
Adjust tests

Does this PR introduce a user-facing change?

No

None

Resolves: #24105

When possible use a generic function to add strings and booleans
Adjust tests

Signed-off-by: Ygal Blum <[email protected]>
@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 1, 2024
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I really like the map approach.

I think for future work we should consider splitting the maps with common options between pod/container out so they both can use the same thing and we do not need to add such option in both places all the time, especially as pod untis currently only supported limed keys. Of course there will still be a bunch of work in adding tests/docs then but hopefully that can be improved as well at some point

Copy link
Contributor

openshift-ci bot commented Oct 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, ygalblum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Oct 2, 2024

LGTM
But tests not happy.

@ygalblum
Copy link
Contributor Author

ygalblum commented Oct 2, 2024

@rhatdan The tests are fine, it's the packit service that's been acting out for a while now. I can see that it's getting 503 when trying to create the build root

@rhatdan
Copy link
Member

rhatdan commented Oct 2, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4eb43de into containers:main Oct 2, 2024
68 of 76 checks passed
@ygalblum
Copy link
Contributor Author

ygalblum commented Oct 2, 2024

@Luap99 you are right. There is more common code in the Convert functions, especially in their beginning.

@ygalblum ygalblum deleted the quadlet-remove-equal-sign branch October 2, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants