Mention no_hosts and base_hosts_file configs in CLI option docs
#24122
Conversation
| @@ -27,3 +28,8 @@ You can prevent that by either giving the **--no-hosts** option, or by setting | |||
| address was configured manually and Podman fails to determine the IP address | |||
| automatically, Podman will silently skip adding these internal hostnames to | |||
| `/etc/hosts`. | |||
|
|
|||
| Podman will use the host's `/etc/hosts` file as a basis by default, i.e. any | |||
| hostname present in this file will also be present in the container's | |||
There was a problem hiding this comment.
nit: i think man pages generally avoid possessive apostrophes (also they do not tend to translate well). if you repush, could you reword as such (ONLY IF YOU PUSH AGAIN).
There was a problem hiding this comment.
I'll have to push again due to the discussion in containers/common#2184. However, I'm not entirely sure what you're suggesting. You mean like "the /etc/hosts file of the host" instead of "the host's /etc/hosts file"? Because especially "the host's" and "the container's" is used all over the docs and the "of the host" appendix feels a bit cumbersome to me as non-native speaker 🙈 I'll rephrase it if that's wished though.
There was a problem hiding this comment.
You mean like "the
/etc/hostsfile of the host" instead of "the host's/etc/hostsfile"?
Correct.
|
nit, only fix if you push again ... else LGTM |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, PhrozenByte The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Follow-up to containers#24043 Signed-off-by: Daniel Rudolf <[email protected]>
PhrozenByte
force-pushed
the
docs-hosts-file
branch
from
c9d950d to
6f9cc37
Compare
|
Updated following containers/common#2184 |
|
/lgtm |
Also mention the
no_hostsandbase_hosts_fileconfigs ofcontainers.confin the docs of the--add-hostsand--no-hostsCLI options.Follow-up to #24043
Related: containers/common#2184
Cc: @Luap99 (feel free to also ping @mheon and @edsantiago)
Does this PR introduce a user-facing change?