Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packit: disable Centos Stream/fedora ELN teasks #24083

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Sep 26, 2024

The go version there is only go 1.22.5 but we need go 1.22.6 as of #24054

It is not clear to me how to best monitor the repos there to see when they get the update. And then there is the fear that podman keeps updating faster then these envs which makes testing there immposible[1]

[1] containers/image#2550 (comment)

Does this PR introduce a user-facing change?

None

The go version there is only go 1.22.5 but we need go 1.22.6 as of
containers#24054

It is not clear to me how to best monitor the repos there to see when
they get the update. And then there is the fear that podman keeps
updating faster then these envs which makes testing there immposible[1]

[1] containers/image#2550 (comment)

Signed-off-by: Paul Holzinger <[email protected]>
@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 26, 2024
@Luap99
Copy link
Member Author

Luap99 commented Sep 26, 2024

@lsm5 PTAL, not sure if this is a good idea (especially the propose downstream for cs10) but I rather not see the failed tests on every PR.

Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm told the golang version on centos stream issue should be resolved soon. And this is going into main so shouldn't be a problem.

I'm still looking into how best to monitor repos. copr cli doesn't have anything built in. I think pkgdb-cli or koji/bodhi could be useful, but we can leave that for later.

/lgtm
/approve
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
Copy link
Contributor

openshift-ci bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Luap99 Luap99 added the No New Tests Allow PR to proceed without adding regression tests label Sep 26, 2024
@lsm5
Copy link
Member

lsm5 commented Sep 27, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 13e4b08 into containers:main Sep 27, 2024
35 checks passed
@Luap99 Luap99 deleted the packit-centos branch September 27, 2024 10:55
@martinpitt
Copy link
Contributor

@lsm5 https://composes.stream.centos.org/stream-10/development/latest-CentOS-Stream/compose/AppStream/x86_64/os/Packages/ has golang 1.23.1, so I suppose this could be re-enabled? I'm asking because someone from the podman team asked us to enable c-podman testing for podman PRs on CentOS. Happy to do that, but we first need podman builds for that.

@lsm5
Copy link
Member

lsm5 commented Oct 14, 2024

@lsm5 https://composes.stream.centos.org/stream-10/development/latest-CentOS-Stream/compose/AppStream/x86_64/os/Packages/ has golang 1.23.1, so I suppose this could be re-enabled?

I'll look into that.

I'm asking because someone from the podman team asked us to enable c-podman testing for podman PRs on CentOS.

That someone was me :) . Thanks for taking this up. I'll let you know once we have green builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. No New Tests Allow PR to proceed without adding regression tests release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants