CORS system test: clean up #24068
Merged
CORS system test: clean up #24068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note-none
approved
edsantiago
added
5.2
and removed
approved
|
Ephemeral COPR build failed. @containers/packit-build please check. |
Luap99
reviewed
Sep 25, 2024
test/system/271-tcp-cors-server.bats
Outdated
| wait_for_port $SERVICE_TCP_HOST $PORT | ||
| cmd="curl -s --max-time 10 -vvv $SERVICE_TCP_HOST:$PORT/_ping" | ||
| echo "$_LOG_PROMPT $cmd" | ||
| run $cmd |
There was a problem hiding this comment.
Should this verify the curl exit code is 0?
There was a problem hiding this comment.
OOPS! Yes, of course. Sometimes I hate bats.
Primary motivator: 'curl -v' format changes in f42 Drive-bys: * 127.0.0.1, not localhost * use wait_for_port, not sleep * show curl commands and their output, to ease debugging failures * better failure assertions Signed-off-by: Ed Santiago <[email protected]>
edsantiago
force-pushed
the
cors-fixes
branch
from
c4cb034 to
73cbc13
Compare
openshift-ci
bot
added
the
approved
|
@edsantiago @Luap99 I'm guessing this is ok to waive for 5.2.3 bodhi? |
|
@lsm5 yes, please waive. This is a silliness failure, not a functional one. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 514d25d
into
containers:main
49 of 55 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary motivator: 'curl -v' format changes in f42
Drive-bys:
Signed-off-by: Ed Santiago [email protected]