refactor: add sshClient function #23893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note-none
do-not-merge/work-in-progress
|
@Luap99 as requested in |
afbjorklund
force-pushed
the
ssh-config-refactor
branch
2 times, most recently
from
7b20ef5 to
8e8582d
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
baude
reviewed
Sep 9, 2024
baude
reviewed
Sep 9, 2024
|
code looks ok to me, couple of questions. |
The ssh options needs some weird parameters like (the raw) uri and machine (insecure), so it is not enough with url and identity. The "secure" query parameter was removed in Podman v4.3, it is now replaced with the "machine" option parameter (InsecureIgnoreHostKey) I think that url.Parse will fail to add any url.Port that is not an integer, so the strconv.Atoi error probably can never happen? But since it is only a validation error and not a connection error, it cannot be wrapped in a ConnectError so that goes into function. Signed-off-by: Anders F Björklund <[email protected]>
afbjorklund
force-pushed
the
ssh-config-refactor
branch
from
8e8582d to
837755e
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
stale-locking-app
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ssh options needs some weird parameters like (the raw) uri and machine (insecure), so it is not enough with url and identity.
i.e. it is not the generic "ssh", but the containers/common "ssh"
The "secure" query parameter was removed in Podman v4.3, it is now replaced with the "machine" option parameter (InsecureIgnoreHostKey)
commit 280f5d8
I think that url.Parse will fail to add any url.Port that is not an integer, so the strconv.Atoi error probably can never happen?
But since it is only a validation error and not a connection error, it cannot be wrapped in a ConnectError so that goes into function.
Does this PR introduce a user-facing change?