Bump Buildah to v1.37.1, c/common v0.60.1, c/image v5.32.1 #23602
Conversation
As the title says. Signed-off-by: tomsweeneyredhat <[email protected]>
TomSweeneyRedHat
added
the
No New Tests
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TomSweeneyRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| github.com/containers/buildah v1.37.0 | ||
| github.com/containers/common v0.60.1-0.20240806133927-05b2e1fd7cd0 | ||
| github.com/containers/buildah v1.37.1 | ||
| github.com/containers/common v0.60.1 |
There was a problem hiding this comment.
This is piratically speaking a downgrade as we were already vendoring c/common from main,
I Still have a open common vendor in #23519 that also shows the you most likely need the test fix from there assuming the "breaking" c/image change was back ported in 5.32.1
There was a problem hiding this comment.
So next steps? Just back this out and vendor directly into the v5.2 branch?
There was a problem hiding this comment.
I would vendor c/common@main here at least.
But without the test fix nothing going to pass so you either cherry-pick that commit or (what I prefer) merge #23519 first and then rebase this.
There was a problem hiding this comment.
I would wait for the 5.2 PR at least until all the test fixes are review/merged at least.
There was a problem hiding this comment.
I've added the test fix for now, off to a meeting, will see add the c/common bump here. I'll talk to @mheon shortly to see if makes sense to cherry-pick this, or just vendor Buildah in the v5.2 branch and add the test fix.
Thanks!
Add a fix to pull to address a zstd:chunked issue as noted in containers/image#2485 Signed-off-by: tomsweeneyredhat <[email protected]>
TomSweeneyRedHat
removed
the
No New Tests
|
I tried reverting c/common to that last version from main, and it backed Buildah out to v1.37.0, which I don't think we want. I've created #23606 to vendor Buildah v1.37.1 directly in Podman v5.2 and I'm going to close this one. |
stale-locking-app
bot
added
the
locked - please file new issue/PR
As the title says.
Does this PR introduce a user-facing change?