Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop APIv2 CNI configuration #23552

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

cevich
Copy link
Member

@cevich cevich commented Aug 8, 2024

Depends on PR #23538

CNI is no longer needed/supported.

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 8, 2024
@cevich cevich changed the title [skip-ci] Drop APIv2 CNI configuration Drop APIv2 CNI configuration Aug 8, 2024
@cevich cevich force-pushed the cleanup_python_cni branch from 62ab781 to 201ddda Compare August 8, 2024 14:41
@Luap99
Copy link
Member

Luap99 commented Aug 9, 2024

There is the same problem in test/apiv2/python/rest_api/fixtures/podman.py

@cevich cevich force-pushed the cleanup_python_cni branch from 201ddda to 2b80d08 Compare August 9, 2024 13:47
**Depends on PR 23538**

CNI is no longer needed/supported.

Signed-off-by: Chris Evich <[email protected]>
@cevich cevich force-pushed the cleanup_python_cni branch from 2b80d08 to a48cd24 Compare August 9, 2024 14:22
@cevich cevich marked this pull request as ready for review August 9, 2024 14:22
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 9, 2024
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented Aug 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2024
@mheon
Copy link
Member

mheon commented Aug 9, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 48e727f into containers:main Aug 9, 2024
46 checks passed
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Nov 8, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants