Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add podman-clean-transient.service service to rootless mode #22749

Merged

Conversation

JayKayy
Copy link
Contributor

@JayKayy JayKayy commented May 19, 2024

Does this PR introduce a user-facing change?

This PR adds the podman-clean-transient.service to the list of installed user services. According to the issue #22317 there should be no reason this would not work in user mode. This seems like it was just forgotten in the original PR: #16892

- Add podman-clean-transient.service as a user service.

Closes #22317

@JayKayy JayKayy changed the title add podman-clean-transient.service service to rootless add podman-clean-transient.service service to rootless mode May 19, 2024
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@mheon
Copy link
Member

mheon commented May 20, 2024

Sure, LGTM.
@alexlarsson PTAL

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
Copy link
Contributor

openshift-ci bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JayKayy, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c8dc5c7 into containers:main May 21, 2024
89 of 91 checks passed
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 20, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podman-clean-transient.service is missing for rootless
3 participants