Correct network option name ip -> ip6
#22509
Conversation
Also, properly capitalize. Signed-off-by: Sander Maijers <[email protected]>
openshift-ci
bot
added
the
do-not-merge/release-note-label-needed
|
Ephemeral COPR build failed. @containers/packit-build please check. |
openshift-ci
bot
added
release-note-none
and removed
do-not-merge/release-note-label-needed
| - **ip=**_IPv6_: Specify a static ipv6 address for this container. | ||
| - **mac=**_MAC_: Specify a static mac address for this container. | ||
| - **ip=**_IPv4_: Specify a static IPv4 address for this container. | ||
| - **ip6=**_IPv6_: Specify a static IPv6 address for this container. |
There was a problem hiding this comment.
technically it does not matter and you can very well set ip=<some ipv6 address>, the backend code mixes them together anyway. But for documentation purposes this makes sense.
There was a problem hiding this comment.
It does matter in my test with Podman Desktop 5.0.2. on MacOS. With ip and an IPv6 address, the container doesn't get the address assigned and with ip6, it does.
There was a problem hiding this comment.
If you use a GUI then why does the cli syntax apply at all?
There was a problem hiding this comment.
Who says I use a GUI? I'm using the CLI, just listed the product.
There was a problem hiding this comment.
Because if you use the cli you cannot say that ip doesn't work for a ipv6 address, the code is literally the same no matter of ip or ip6
podman/pkg/specgen/namespaces.go
Line 448 in 9ac6d9d
There was a problem hiding this comment.
Maybe you can also test it, looks can be deceptive.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, sanmai-NL The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
openshift-merge-bot
bot
merged commit 3927a52
into
containers:main
stale-locking-app
bot
added
the
locked - please file new issue/PR
Also, properly capitalize.
Does this PR introduce a user-facing change?