-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix function names in comment #22481
Conversation
Signed-off-by: findnature <[email protected]>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: findnature, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override "Total Success" |
@Luap99: Overrode contexts on behalf of Luap99: Total Success In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
Does not appear to have worked, unfortunately. |
Probably Github gating the merge - branch protection says Total Success must pass. |
yeah, was just playing around. I did not expect it to work tbh. |
What a shock, the registry is flaking. Restarted all. |
/hold |
@findnature Mind rebasing to fix the failing tests? |
Sorry, I haven't figured out why changing the method name in the comment would affect the build. I don't have Fedora's device, but I guess it may be related to the modification of newManifestListBuilder in pkg/farm/list_builder. go? Should I roll back the modifications here (although they should not cause the build to fail) |
Sorry for causing this issue
Sorry for causing this issue |
Rebased! |
Ephemeral COPR build failed. @containers/packit-build please check. |
@findnature Not your problem, we tried to work around broken CI with the override and unintentionally broke it worse. /lgtm |
195d100
into
containers:main
Does this PR introduce a user-facing change?
No