Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix function names in comment #22481

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

findnature
Copy link
Contributor

Does this PR introduce a user-facing change?

No

 fix function names in comment

@mheon
Copy link
Member

mheon commented Apr 24, 2024

/approve
Code LGTM

Copy link
Contributor

openshift-ci bot commented Apr 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: findnature, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2024
@mheon mheon added the No New Tests Allow PR to proceed without adding regression tests label Apr 24, 2024
@Luap99
Copy link
Member

Luap99 commented Apr 24, 2024

/override "Total Success"

Copy link
Contributor

openshift-ci bot commented Apr 24, 2024

@Luap99: Overrode contexts on behalf of Luap99: Total Success

In response to this:

/override "Total Success"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Luap99
Copy link
Member

Luap99 commented Apr 24, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
@mheon
Copy link
Member

mheon commented Apr 24, 2024

Does not appear to have worked, unfortunately.

@mheon
Copy link
Member

mheon commented Apr 24, 2024

Probably Github gating the merge - branch protection says Total Success must pass.

@Luap99
Copy link
Member

Luap99 commented Apr 24, 2024

Probably Github gating the merge - branch protection says Total Success must pass.

yeah, was just playing around. I did not expect it to work tbh.

@mheon
Copy link
Member

mheon commented Apr 24, 2024

# Error: initializing source docker://quay.io/libpod/testimage@sha256:17823456328e5f38b2c0dc7f9453aee0196654dba39ae2220f869717f159159a: can't talk to a V1 container registry

What a shock, the registry is flaking. Restarted all.

@mheon
Copy link
Member

mheon commented Apr 25, 2024

/hold
Bit concerned this may be blocking the merge pool.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2024
@mheon
Copy link
Member

mheon commented Apr 25, 2024

@findnature Mind rebasing to fix the failing tests?

@findnature
Copy link
Contributor Author

@findnature Mind rebasing to fix the failing tests?

Sorry, I haven't figured out why changing the method name in the comment would affect the build. I don't have Fedora's device, but I guess it may be related to the modification of newManifestListBuilder in pkg/farm/list_builder. go? Should I roll back the modifications here (although they should not cause the build to fail)

@findnature
Copy link
Contributor Author

/hold /拿 Bit concerned this may be blocking the merge pool.有点担心这可能会阻止合并池。

Sorry for causing this issue

/hold Bit concerned this may be blocking the merge pool.

Sorry for causing this issue

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
@findnature
Copy link
Contributor Author

@findnature Mind rebasing to fix the failing tests?

Rebased!

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@mheon
Copy link
Member

mheon commented Apr 26, 2024

@findnature Not your problem, we tried to work around broken CI with the override and unintentionally broke it worse.

/lgtm
/hold cancel

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 26, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 195d100 into containers:main Apr 26, 2024
88 of 90 checks passed
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jul 26, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. No New Tests Allow PR to proceed without adding regression tests release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants