-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust some tests to work with Zstd in containers.conf #21793
Adjust some tests to work with Zstd in containers.conf #21793
Conversation
When we want the original image to be gzip, explicitly ask for that instead of assuming the containers.conf defaults do that. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
When we want the original image to be gzip, explicitly ask for that instead of assuming the containers.conf defaults do that. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
LGTM. All build tasks are Quay flakes. Restarted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/hold cancel |
These are immediately-applicable parts of #21571 , so that tests which require gzip compression to be used don’t rely on the
containers.conf
default.That this does work with Zstd can be verified in #21571.
Does this PR introduce a user-facing change?