-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gvproxy: Update to 0.7.2 release #21278
gvproxy: Update to 0.7.2 release #21278
Conversation
This updates the Windows installer and macOS installer to ship the newer binaries, as well as the vendored gvisor-tap-vsock code. [NO NEW TESTS NEEDED] Signed-off-by: Christophe Fergeau <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@gbraad: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This release solves several issues related to AppleHV (vfkit) |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, cfergeau, gbraad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick v4.9 |
@baude: once the present PR merges, I will cherry-pick it on top of v4.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold cancel |
/hold cancel |
1c81798
into
containers:main
@baude: #21278 failed to apply on top of branch "v4.9":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mheon auto cherrypick failed here. |
I don't know in which branch/PR/... the cherry-pick happens, but I've rebased https://github.com/cfergeau/podman/commits/gvisor-tap-vsock-update/ on top of the v4.9 branch and resolved the conflict (roughly |
This updates the Windows installer and macOS installer to ship the newer
binaries, as well as the vendored gvisor-tap-vsock code.
[NO NEW TESTS NEEDED]
Does this PR introduce a user-facing change?
(unless you track version updates of the modules you are using, in which case this would become "Update gvisor-tap-vsock binaries to 0.7.2 - this fixes a startup race condition when using applehv")