[v4.9] Add a net health recovery service to qemu machines #21276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: n1hility The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
We're not doing another 4.8 release, so not necessary |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
Sorry got myself confused meant 4.9 |
|
Validate is angry, you need a quick gofmt and then we can merge |
n1hility
force-pushed
the
net-recovery-49
branch
from
67e0076 to
6e674b3
Compare
|
/lgtm |
|
CI still complaining about gofmt |
|
@n1hility can you fix the gofmt issue? |
n1hility
force-pushed
the
net-recovery-49
branch
from
6e674b3 to
ddccab5
Compare
|
not sure what happened there should be fixed now, i will keep an eye on it |
There is a network stability issue in qemu + virtio, affecting some users after long periods of usage, which can lead to suspended queue delivery. Until the issue is resolved, add a temporary recovery service which restarts networking when host communication becomes inoperable. [NO NEW TESTS NEEDED] Signed-off-by: Jason T. Greene <[email protected]>
n1hility
force-pushed
the
net-recovery-49
branch
from
ddccab5 to
6c173c0
Compare
|
/lgtm |
|
/lgtm |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #21262