Add tests to make sure mounts.conf does not warn on missing content #21272
Conversation
openshift-ci
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
test/system/030-run.bats
Outdated
| skip_if_remote "--default-mounts-file is not supported for remote clients" | ||
| MOUNTS_CONF=$PODMAN_TMPDIR/mounts.conf | ||
| run_podman run --rm --default-mounts-file=${MOUNTS_CONF} $IMAGE echo test1 | ||
| assert "$output" = "test1" "No warning messages" |
There was a problem hiding this comment.
Request: unique test failure messages: "No warning messages with missing mounts.conf", "...with empty mounts.conf", "with bogus mounts.conf". That makes it so much nicer for the monkey looking at test failures.
rhatdan
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
test/system/030-run.bats
Outdated
| randcontent=$(random_string 30) | ||
| mkdir -p $PODMAN_TMPDIR/mounts | ||
| echo $randcontent > $PODMAN_TMPDIR/mounts/$randfile | ||
| echo $PODMAN_TMPDIR/mounts:/run/secrets > $PODMAN_TMPDIR/mounts.conf |
There was a problem hiding this comment.
Could use ${MOUNTS_CONF} instead of $PODMAN_TMPDIR/mounts.conf for consistency. Same for the other reference above.
rhatdan
force-pushed
the
VENDOR
branch
2 times, most recently
from
5315c33 to
7197204
Compare
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
Signed-off-by: Daniel J Walsh <[email protected]>
|
@edsantiago @vrothberg @ashley-cui @baude @giuseppe @umohnani8 @Luap99 merge me. |
|
LGTM |
|
LGTM |
|
/lgtm |
openshift-merge-bot
bot
merged commit 11c37d5
into
containers:main
stale-locking-app
bot
added
the
locked - please file new issue/PR
Does this PR introduce a user-facing change?