-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FreeBSD] Fix crash when running podman inspect #21253
Conversation
@lsm5 Not entirely sure how to proceed here given there is no reviewer listed in the comment from the bot above. On the unit testing front, given there is no FreeBSD CI not sure how to best unit test this as it would require setting up quite a bit of scaffolding to force c.config.Spec.Linux to be false on a Linux system - if that is even possible (and is something that probably requires more knowledge of the codebase than I possess i'm afraid) |
You can add '[NO NEW TESTS NEEDED]' to the commit message which will fix the validation failures. FreeBSD CI is limited to making sure it builds at the moment. |
When preparing container inspection output, ensure we actually have masked paths to work with. These will only be available on Linux, which is no longer always true as we also support FreeBSD now. Fixes containers#21117 Signed-off-by: Ben Cooksley <[email protected]>
Thanks, have done so now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @bcooksley
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bcooksley, edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
85921e5
into
containers:main
When preparing container inspection output, ensure we actually have masked paths to work with.
These will only be available on Linux, which is no longer always true as we also support FreeBSD now.
Fixes #21117
Does this PR introduce a user-facing change?