Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FreeBSD] Fix crash when running podman inspect #21253

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

bcooksley
Copy link
Contributor

When preparing container inspection output, ensure we actually have masked paths to work with.
These will only be available on Linux, which is no longer always true as we also support FreeBSD now.

Fixes #21117

Does this PR introduce a user-facing change?

None

@bcooksley
Copy link
Contributor Author

@lsm5 Not entirely sure how to proceed here given there is no reviewer listed in the comment from the bot above.

On the unit testing front, given there is no FreeBSD CI not sure how to best unit test this as it would require setting up quite a bit of scaffolding to force c.config.Spec.Linux to be false on a Linux system - if that is even possible (and is something that probably requires more knowledge of the codebase than I possess i'm afraid)

@dfr
Copy link
Contributor

dfr commented Jan 14, 2024

@lsm5 Not entirely sure how to proceed here given there is no reviewer listed in the comment from the bot above.

On the unit testing front, given there is no FreeBSD CI not sure how to best unit test this as it would require setting up quite a bit of scaffolding to force c.config.Spec.Linux to be false on a Linux system - if that is even possible (and is something that probably requires more knowledge of the codebase than I possess i'm afraid)

You can add '[NO NEW TESTS NEEDED]' to the commit message which will fix the validation failures. FreeBSD CI is limited to making sure it builds at the moment.

When preparing container inspection output, ensure we actually have masked paths to work with.
These will only be available on Linux, which is no longer always true as we also support FreeBSD now.

Fixes containers#21117

Signed-off-by: Ben Cooksley <[email protected]>
@bcooksley
Copy link
Contributor Author

Thanks, have done so now.

Copy link
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @bcooksley

Copy link
Contributor

openshift-ci bot commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bcooksley, edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2024
@rhatdan
Copy link
Member

rhatdan commented Jan 16, 2024

/lgtm
Thanks @bcooksley

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 85921e5 into containers:main Jan 16, 2024
90 of 92 checks passed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Apr 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"podman inspect" triggers SIGSEGV on FreeBSD
4 participants