Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.4.1-crio] Bump c/storage to 1.46.1 #21132

Merged

Conversation

TomSweeneyRedHat
Copy link
Member

After discussions with @mheon today, we decided to create a new branch entitled v4.4.1-crio. The issue is seen only in OCP 4.12, later versions of OCP have an updated c/storage and don't run into this.

As this is not a change that we want to add to the 4.4.1-rhel stream, we decided to create a new branch.

This replaces: #20881

Addresses: https://issues.redhat.com/browse/OCPBUGS-17043

[NO NEW TESTS NEEDED]

Does this PR introduce a user-facing change?

None

After discussions with @mheon today, we decided to create a new branch
entitled v4.4.1-crio.  The issue is seen only in OCP 4.12, later
versions of OCP have an updated c/storage and don't run into this.

As this is not a change that we want to add to the 4.4.1-rhel stream,
we decided to create a new branch.

This replaces: containers#20881

Addresses: https://issues.redhat.com/browse/OCPBUGS-17043

[NO NEW TESTS NEEDED]

Signed-off-by: TomSweeneyRedHat <[email protected]>
Copy link
Contributor

openshift-ci bot commented Jan 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2024
@TomSweeneyRedHat
Copy link
Member Author

@mheon and if you have time @vrothberg, PTAL

This is the first time that I've created a release-branch upstream from another one from upstream. Here are the git commands I used:

     git fetch --all
     git rebase upstream/main
     git checkout -b v4.4.1-crio
     git reset --hard b9594a7
     git push upstream v4.4.1-crio

b9594a7 is the top-level commit in the v4.4.1-rhel branch.

The above command created this PR: #21131, which I was not expecting and just created as a draft and summarily closed.

For this PR, I then bumped c/storage to v1.46.1. The only odd thing is the `make vendor-in-container' command somehow dragged in the file docs/source/markdown/podman-compose.1.md, and I'm not sure how that was possibly pulled in during the vendoring as that was added back in June, and there's no other compose pieces that I can see. I did not commit that file.

Please let me know if I need to redo or adjust any of this.

@mheon
Copy link
Member

mheon commented Jan 3, 2024 via email

@mheon
Copy link
Member

mheon commented Jan 5, 2024

I'm going to go ahead and push the button.

@mheon mheon merged commit b8d5c9b into containers:v4.4.1-crio Jan 5, 2024
25 of 55 checks passed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Apr 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants