Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] docs/build_osx.md: Describe external gvproxy #21110

Merged

Conversation

cgwalters
Copy link
Contributor

I think many podman-MacOS developers will fit into what this doc section describes.

None

@baude
Copy link
Member

baude commented Jan 1, 2024

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 1, 2024
@baude
Copy link
Member

baude commented Jan 1, 2024

LGTM, but I thought this very recently changed and may not be needed any more ?

@rhatdan
Copy link
Member

rhatdan commented Jan 2, 2024

@gbraad @ashley-cui PTAL

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's easier/more straight-forward to change helper_binaries_dir= in containers.conf.

I think many podman-MacOS developers will fit into what this
doc section describes.

Signed-off-by: Colin Walters <[email protected]>
@cgwalters cgwalters force-pushed the doc-external-gvproxy branch from 7febb7d to f9de980 Compare January 2, 2024 18:31
@cgwalters
Copy link
Contributor Author

I think it's easier/more straight-forward to change helper_binaries_dir= in containers.conf.

Hmm. Some different tradeoffs there; that would affect the main podman binary too (which is fine) but logically the goal here is to have two podman setups.

So I'm not totally sure it's universally better; to avoid debate I ended up just documenting that in addition too.

@rhatdan
Copy link
Member

rhatdan commented Jan 2, 2024

/approve
/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 2, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2024
Copy link
Contributor

openshift-ci bot commented Jan 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, cgwalters, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrothberg
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 3, 2024
@vrothberg
Copy link
Member

Hmm. Some different tradeoffs there; that would affect the main podman binary too (which is fine) but logically the goal here is to have two podman setups.

CONTAINERS_CONF=/path/to/special.conf podman ... would work without impacting other users/binaries. Or --module /path/to/special.conf.

@openshift-merge-bot openshift-merge-bot bot merged commit 45c3e76 into containers:main Jan 3, 2024
40 checks passed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Apr 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants