-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:DOCS] docs/build_osx.md: Describe external gvproxy #21110
[CI:DOCS] docs/build_osx.md: Describe external gvproxy #21110
Conversation
/approve |
LGTM, but I thought this very recently changed and may not be needed any more ? |
@gbraad @ashley-cui PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's easier/more straight-forward to change helper_binaries_dir=
in containers.conf.
I think many podman-MacOS developers will fit into what this doc section describes. Signed-off-by: Colin Walters <[email protected]>
7febb7d
to
f9de980
Compare
Hmm. Some different tradeoffs there; that would affect the main podman binary too (which is fine) but logically the goal here is to have two podman setups. So I'm not totally sure it's universally better; to avoid debate I ended up just documenting that in addition too. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, cgwalters, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
|
I think many podman-MacOS developers will fit into what this doc section describes.