Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Skip journalctl if journald is unavailable #21107

Merged

Conversation

ttsuuubasa
Copy link
Contributor

Test "podman start container by systemd" is failed on the system in which rootless users don't have accessibility to journald. Therefore, skip the part that reads journal with journalctl.

Does this PR introduce a user-facing change?

None

@rhatdan
Copy link
Member

rhatdan commented Dec 30, 2023

Lint does not like the whitespace.

/approve
LGTM
Thanks @fj-tsubasa

Copy link
Contributor

openshift-ci bot commented Dec 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fj-tsubasa, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2023
Test "podman start container by systemd" is failed on the system in
which rootless users don't have accessibility to journald. Therefore,
skip the part that reads journal with journalctl.

Signed-off-by: Tsubasa Watanabe <[email protected]>
@ttsuuubasa ttsuuubasa force-pushed the e2e-systemd_test-journald branch from 74abf79 to ec5422a Compare December 31, 2023 06:31
@ttsuuubasa
Copy link
Contributor Author

I have removed the whitespace that lint hated.

@baude
Copy link
Member

baude commented Jan 1, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 1, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4419924 into containers:main Jan 1, 2024
77 of 78 checks passed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Apr 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants