-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mmap cache option to QEMU mount #21089
Add mmap cache option to QEMU mount #21089
Conversation
This is required for mmap'ing on mounted files on MacOS Host. Closes containers#19639, containers#20055. Signed-off-by: Byoungchan Lee <[email protected]>
ab07cb7
to
f10a7bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hit the problem described here when using devcontainers; at least cargo/rustc use mmap
to access some bits in the build process.
I've verified this PR fixes the problem.
/approve |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, bc-lee, cgwalters The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
are there implications for linux and qemu ? also, it should be noted that qemu will be deprecated on mac in podman 5 in favor of the apple hypervisor |
If someone uses Podman on Linux with QEMU, then they are also affected by this PR, for the same reasons.
I didn't know that. Thanks for the info. FYI, I have some machines/users that still use Podman with Amd64 macOS machines, so I hope that Podman will continue to support QEMU implementation for a while. |
This is required for mmap'ing on mounted files on MacOS Host. Closes #19639, #20055.
Does this PR introduce a user-facing change?