[CI:DOCS] xref-manpages script: more regression tests #21072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
do-not-merge/work-in-progress
|
Marking as draft because there's no need to commit this before holiday break. I just want to leave it in a safe place. |
|
Chicken :^) Have a good holiday |
edsantiago
force-pushed
the
xref-manpage-tests
branch
from
bceab24 to
95463c2
Compare
edsantiago
added
do-not-merge/blocked-paths
edsantiago
force-pushed
the
xref-manpage-tests
branch
from
95463c2 to
7e84694
Compare
openshift-ci
bot
removed
the
do-not-merge/invalid-owners-file
edsantiago
removed
do-not-merge/work-in-progress
Followup to containers#21055: regression tests for the code that reads man pages. These are not xref-related at all, just simple consistency checks on the man page content. In the process of writing these tests, I also fixed a longstanding bug where warning messages could be emitted multiple times, once for each time we read a man page file (as happens with command aliases). Signed-off-by: Ed Santiago <[email protected]>
edsantiago
force-pushed
the
xref-manpage-tests
branch
from
7e84694 to
4508620
Compare
|
@containers/podman-maintainers PTAL. I think this is safe to merge. The risk is the new dependency on |
|
LGTM on my end, but I'm not the best at scripting |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #21055: regression tests for the code that
reads man pages. These are not xref-related at all, just
simple consistency checks on the man page content.
In the process of writing these tests, I also fixed a
longstanding bug where warning messages could be emitted
multiple times, once for each time we read a man page file
(as happens with command aliases).
Signed-off-by: Ed Santiago [email protected]