-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable pid max in the podman machine #21061
Conversation
63e2dfb
to
f845ed0
Compare
@benoitf can you rebase and see if the tests go better for you ? |
@baude rebased |
LGTM |
@benoitf needs a rebase? |
fix podman-desktop/podman-desktop#5282 With FCOS we have a limit of 2048 files But when launching containers like kind containers, we're reaching easily the limit. AFAIK as it's inside a dedicated machine, limit should be max Limit should be only at the container level. Signed-off-by: Florent Benoit <[email protected]>
@rhatdan done, thanks for the reminder |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benoitf, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cb473e8
into
containers:main
/cherry-pick v4.8 |
@ashley-cui: new pull request created: #21221 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Does this PR introduce a user-facing change?
fix podman-desktop/podman-desktop#5282
With FCOS we have a limit of 2048 files.
But when launching containers like kind containers, we're reaching easily the limit.
(kind create command is not providing
AFAIK as it's inside a dedicated machine, there should not be any limit
The limit should be only set when running a container.
default = unlimited
if using
--pids-limit=<something>
then it's using this value.If I use docker I have the same behaviour:
[NO NEW TESTS NEEDED]
Release notes: