Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable pid max in the podman machine #21061

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Dec 19, 2023

Does this PR introduce a user-facing change?

fix podman-desktop/podman-desktop#5282

With FCOS we have a limit of 2048 files.
But when launching containers like kind containers, we're reaching easily the limit.
(kind create command is not providing
AFAIK as it's inside a dedicated machine, there should not be any limit

The limit should be only set when running a container.

default = unlimited
if using --pids-limit=<something> then it's using this value.

If I use docker I have the same behaviour:

docker run --rm -it fedora cat  /sys/fs/cgroup/pids.max                                                                                                                                
max

[NO NEW TESTS NEEDED]

Release notes:

feat: disable pids-limit inside a podman machine.

@baude
Copy link
Member

baude commented Jan 3, 2024

@benoitf can you rebase and see if the tests go better for you ?

@benoitf
Copy link
Contributor Author

benoitf commented Jan 3, 2024

@baude rebased

@rhatdan
Copy link
Member

rhatdan commented Jan 3, 2024

LGTM

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2024
@rhatdan
Copy link
Member

rhatdan commented Jan 8, 2024

@benoitf needs a rebase?

fix podman-desktop/podman-desktop#5282

With FCOS we have a limit of 2048 files
But when launching containers like kind containers, we're reaching
easily the limit.
AFAIK as it's inside a dedicated machine, limit should be max
Limit should be only at the container level.

Signed-off-by: Florent Benoit <[email protected]>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2024
@benoitf
Copy link
Contributor Author

benoitf commented Jan 8, 2024

@rhatdan done, thanks for the reminder

@rhatdan
Copy link
Member

rhatdan commented Jan 10, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
Copy link
Contributor

openshift-ci bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benoitf, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit cb473e8 into containers:main Jan 10, 2024
91 of 92 checks passed
@ashley-cui
Copy link
Member

/cherry-pick v4.8

@openshift-cherrypick-robot
Copy link
Collaborator

@ashley-cui: new pull request created: #21221

In response to this:

/cherry-pick v4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Apr 15, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. machine podman-desktop release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KinD cluster max process is way too low
6 participants