remote: fix podman-remote container checkpoint --compress #21056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fj-tsubasa The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions
bot
added
the
kind/api-change
|
Thanks, This looks good. I am not sure what is going on with the tests, but did you run make generate-bindings |
ttsuuubasa
force-pushed
the
podman-remote-compression
branch
3 times, most recently
from
82bf6d5 to
c835737
Compare
Fix `podman container checkpoint --compress` to work in remote environment. Signed-off-by: Tsubasa Watanabe <[email protected]>
ttsuuubasa
force-pushed
the
podman-remote-compression
branch
from
c835737 to
87d3ae2
Compare
|
I've done "make generate-bindings" and committed the changes. |
|
Could you please comment somewhat? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
podman container checkpoint --compressto work in remote environment.Currently, whichever a compression type (zstd, gzip, none) is selected, the exported file is compressed with "none" as the following.
This PR enable the command to compress the exported file with the selected compression type.
I have added the function for checking a compression type of the exported file into e2e test.
Does this PR introduce a user-facing change?