Auto-correct previous bad image installs of podman-net-usermode #21014
Conversation
openshift-ci
bot
added
release-note
approved
|
/cherry-pick v4.8 |
|
@n1hility: once the present PR merges, I will cherry-pick it on top of v4.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
n1hility
changed the title
n1hility
changed the title
pkg/machine/wsl/usermodenet.go
Outdated
| @@ -29,6 +29,8 @@ fi | |||
| if [[ ! $ROUTE =~ default\ via ]]; then | |||
| exit 3 | |||
| fi | |||
| # auto-correct previous installs of known bad image v39.0.3 | |||
| test -x /usr/local/bin/vm || chmod 755 /usr/local/bin/vm | |||
There was a problem hiding this comment.
any reason to do the test vs just always the chmod?
There was a problem hiding this comment.
no real convincing reason, other than to save an exec since test is a builtin, but that won't really make any discernible difference, so I just changed it.
v39.0.1-3 introduced an update to gvforwarder with defunct perms. Detect and correct this condition so that users do not need to reinit a fresh user-mode dist. [NO NEW TESTS NEEDED] Signed-off-by: Jason T. Greene <[email protected]>
n1hility
force-pushed
the
autofix-usermode
branch
from
cf336a6 to
6321013
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, n1hility The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
A friendly reminder that this PR had no activity for 30 days. |
|
@n1hility Do we still need this? |
|
no longer relevant |
stale-locking-app
bot
added
the
locked - please file new issue/PR
Additional improvement to resolution of #20982
v39.0.1-3 introduced an update to gvforwarder with defunct perms. Detect and correct this condition so that users do not need to reinit a fresh user-mode dist.