-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CheckExclusiveArch should use local JSON too #21009
CheckExclusiveArch should use local JSON too #21009
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When performing CheckExclusiveArch, we should get a list of VMs that exist on disk (JSON). We should then iterate those and checking if they are running in HyperV. [NO NEW TESTS NEEDED] Signed-off-by: Brent Baude <[email protected]>
4df99b1
to
3a84202
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
} | ||
// hyperv does not know about it, move on | ||
if !exists { // hot path | ||
// TODO should we logrus this to show we found a JSON with no hyperv vm ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
properly ok to not log this here. I think for something like machine ls it should be logged as error but if I start one machine I don't think there is a point in erroring about another machine config problem.
/lgtm |
9c16f1b
into
containers:main
/cherry-pick v4.8 |
@baude: #21009 failed to apply on top of branch "v4.8":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When performing CheckExclusiveArch, we should get a list of VMs that exist on disk (JSON). We should then iterate those and checking if they are running in HyperV.
[NO NEW TESTS NEEDED]
Does this PR introduce a user-facing change?