-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v4.4.1-rhel] remote,build: error if containerignore is symlink #20991
[v4.4.1-rhel] remote,build: error if containerignore is symlink #20991
Conversation
Drop support for remote use-cases when `.containerignore` or `.dockerignore` is a symlink pointing to arbitrary location on host. Addresses: https://issues.redhat.com/browse/RHEL-13468 and https://issues.redhat.com/browse/RHEL-16395 CVE-2022-4122 Signed-off-by: Aditya R <[email protected]> Signed-off-by: TomSweeneyRedHat <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TomSweeneyRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hrmmm, yes it's enabled and monitored. The most recent branch-level run happened and passed. Investigating... |
Ahh, I noticed other branches had switched the tests to use a different image. So it's possible/maybe something is broken just with @edsantiago does any of this jive with your knowledge or recollection? Is it fixed or still an ongoing problem do you know? |
Thanks Ed, I knew this problem seemed familiar somehow, thanks for connecting the dots 🤣 |
Thanks @edsantiago and @cevich I'd completely forgotten @lsm5 had submitted that. Too many balls up in the air. I'm going to close this and we'll chase down the error in the other PR> |
Drop support for remote use-cases when
.containerignore
or.dockerignore
is a symlink pointing to arbitrary location on host.Addresses: https://issues.redhat.com/browse/RHEL-13468 and
https://issues.redhat.com/browse/RHEL-16395
CVE-2022-4122
Picked from #16315
Does this PR introduce a user-facing change?