cli: use StringArray over StringSlice Part 2 #20976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
For reference part 1: #20945 |
|
All I have time for today is a first-pass review, but I've done so, commit by commit, and it LGTM. Nice work. |
This option accepts a file path so we should allow commas in it. Signed-off-by: Paul Holzinger <[email protected]>
This option accepts a file path so we should allow commas in it. Also add tests for --decryption-key Signed-off-by: Paul Holzinger <[email protected]>
This option accepts a file path so we should allow commas in it. There ar eno tests for this option, I have no idea what this option does nor how to use it so I cannot write one. Signed-off-by: Paul Holzinger <[email protected]>
This option accepts arbitrary input so we should allow commas in it. Signed-off-by: Paul Holzinger <[email protected]>
If a user did not set an equal sign in the annotation that old code would panic when accessing the second element in the slice. Signed-off-by: Paul Holzinger <[email protected]>
This option accepts arbitrary input so we should allow commas in it. Signed-off-by: Paul Holzinger <[email protected]>
This option accepts a file path so we should allow commas in it. Signed-off-by: Paul Holzinger <[email protected]>
This option accepts arbitrary input so we should allow commas in it. Signed-off-by: Paul Holzinger <[email protected]>
This option accepts arbitrary input so we should allow commas in it. Signed-off-by: Paul Holzinger <[email protected]>
|
LGTM again |
|
/lgtm |
openshift-merge-bot
bot
merged commit 5db4224
into
containers:main
89 of 92 checks passed
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains part 2 of the StringArray changes, with that all options I could clearly identify as accepting arbitrary input are converted. There are still a lot of StringSlice() calls used but these seem to accept "well defined" values, for example ip addresses. Thus I decided to leave them alone for now because I do not want to introduce breaking changes were it is not required.
see commits for details
Does this PR introduce a user-facing change?