Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V4.8.1 bump #20907

Merged
merged 3 commits into from
Dec 5, 2023
Merged

V4.8.1 bump #20907

merged 3 commits into from
Dec 5, 2023

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Dec 5, 2023

Does this PR introduce a user-facing change?

None

lsm5 added 3 commits December 5, 2023 13:38
@lsm5
Update RELEASE_NOTES.md for v4.8.1
0b72d1b 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
v4.8.1
ef6e5ac 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
bump version to v4.8.2-dev
b0e2ffc 
Signed-off-by: Lokesh Mandvekar <[email protected]>
@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 5, 2023
@lsm5
Copy link
Member Author

lsm5 commented Dec 5, 2023

@Luap99 @TomSweeneyRedHat @containers/podman-maintainers PTAL

flouthoc
flouthoc approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vrothberg
vrothberg approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg
Copy link
Member

Leaving merge up to @Luap99 to double-check whether all backports are in-place.

giuseppe
giuseppe approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Luap99
Luap99 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Dec 5, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, giuseppe, lsm5, Luap99, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Luap99,flouthoc,giuseppe,lsm5,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lsm5
Copy link
Member Author

lsm5 commented Dec 5, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit fc78e10 into containers:v4.8 Dec 5, 2023
91 of 92 checks passed
@lsm5 lsm5 deleted the v4.8.1-bump branch December 5, 2023 11:42
@TomSweeneyRedHat
Copy link
Member

Way late, but LGTM

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Mar 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 approved these changes

@vrothberg vrothberg vrothberg approved these changes

@flouthoc flouthoc flouthoc approved these changes

@giuseppe giuseppe giuseppe approved these changes

Assignees

@Luap99 Luap99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lsm5 @vrothberg @TomSweeneyRedHat @giuseppe @flouthoc @Luap99