Fix locking error in WSL machine rm -f #20841
Conversation
|
/cherry-pick v4.8 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashley-cui The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@ashley-cui: once the present PR merges, I will cherry-pick it on top of v4.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixed a bug where `podman machine rm -f` would cause a deadlock when running with WSL. The deadlock is caused by the Remove() function calling the Stop() function after Remove() locks the VM. Stop() also has a lock call, which fails and deadlocks because Remove() already claimed lock. Fix this by moving the stop call before the lock [NO NEW TESTS NEEDED] Signed-off-by: Ashley Cui <[email protected]>
ashley-cui
force-pushed
the
wsldeadlock
branch
from
b8eaf15 to
42ea211
Compare
|
LGTM |
|
/lgtm |
openshift-ci
bot
added
do-not-merge/hold
openshift-ci
bot
removed
the
do-not-merge/hold
|
@ashley-cui: new pull request created: #20849 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
github-actions
bot
added
the
locked - please file new issue/PR
Fixed a bug where
podman machine rm -fwould cause a deadlock when running with WSL.The deadlock is caused by the Remove() function calling the Stop() function after Remove() locks the VM. Stop() also has a lock call, which fails and deadlocks because Remove() already claimed lock. Fix this by moving the stop call before the lock
[NO NEW TESTS NEEDED]
Does this PR introduce a user-facing change?