[systests] podman mount no-dereference: complete rewrite #20799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
|
Marked draft because I really, really want this on top of #20797. That was SO HELPFUL in debugging this! @vrothberg WDYT of this approach? (V. low priority) |
vrothberg
approved these changes
Nov 28, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Existing test was very good, but as a multidimensional table it was unmaintainable... and actually missed one corner case. This version isn't much better. It's far longer, codewise. It is a little harder to understand at first glance. It has three uncomfortable magic conditionals. But I believe it is more long-term maintainable: beyond the first glance, it is possible for a human to check it for correctness. It is also extensible, as proved by the new test cases I added. Signed-off-by: Ed Santiago <[email protected]>
edsantiago
force-pushed
the
symlink-mounts
branch
from
089f012 to
c664cfe
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
Thanks. Rebased & repushed with |
|
/lgtm |
openshift-merge-bot
bot
merged commit 21951e2
into
containers:main
92 of 93 checks passed
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing test was very good, but as a multidimensional table it
was unmaintainable... and actually missed one corner case.
This version isn't much better. It's far longer, codewise. It
is a little harder to understand at first glance. It has three
uncomfortable magic conditionals. But I believe it is more
long-term maintainable: beyond the first glance, it is possible
for a human to check it for correctness. It is also extensible,
as proved by the new test cases I added.