Create pkg/machine/ignition package
#20692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
|
Cockpit tests failed for commit eea255da6c91e08f8024e9e8e5f66c18d9860771. @martinpitt, @jelly, @mvollmer please check. |
jakecorrenti
force-pushed
the
ignition-pkg
branch
8 times, most recently
from
f0bfaa5 to
2b25beb
Compare
openshift-merge-robot
added
the
needs-rebase
jakecorrenti
force-pushed
the
ignition-pkg
branch
from
2b25beb to
5f9b4e2
Compare
openshift-merge-robot
removed
the
needs-rebase
|
Ephemeral COPR build failed. @containers/packit-build please check. |
jakecorrenti
force-pushed
the
ignition-pkg
branch
from
5f9b4e2 to
54ecb69
Compare
jakecorrenti
force-pushed
the
ignition-pkg
branch
2 times, most recently
from
c7aba47 to
e06ef85
Compare
openshift-merge-robot
added
the
needs-rebase
jakecorrenti
force-pushed
the
ignition-pkg
branch
from
e06ef85 to
0c02154
Compare
openshift-merge-robot
removed
the
needs-rebase
jakecorrenti
force-pushed
the
ignition-pkg
branch
from
0c02154 to
eda517a
Compare
jakecorrenti
changed the title
pkg/machine/ignition packagepkg/machine/ignition package
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@baude @ashley-cui PTAL |
rhatdan
reviewed
Dec 3, 2023
jakecorrenti
force-pushed
the
ignition-pkg
branch
from
eda517a to
d4584b8
Compare
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakecorrenti, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-robot
added
the
needs-rebase
jakecorrenti
force-pushed
the
ignition-pkg
branch
from
d4584b8 to
a8e7715
Compare
openshift-merge-robot
removed
the
needs-rebase
jakecorrenti
force-pushed
the
ignition-pkg
branch
from
a8e7715 to
20c1924
Compare
jakecorrenti
force-pushed
the
ignition-pkg
branch
2 times, most recently
from
20c1924 to
4273de0
Compare
|
still trying to narrow down what's causing these errors, so apologies for the loads of pushes. the errors only turned up after the rebase... |
jakecorrenti
force-pushed
the
ignition-pkg
branch
2 times, most recently
from
3b8cf9f to
ee74907
Compare
|
both failures seem to be unrelated |
Moves all of the ignitionfiles out of the `machine` package and into its own called `ignition`. This required `VMType` to get moved out of the `machine` package and into the `define` package in order to prevent a circular dependency. Signed-off-by: Jake Correnti <[email protected]>
Uses the systemd unit file parser to build unit files instead of having them be just blocks of hard-coded strings. Signed-off-by: Jake Correnti <[email protected]>
jakecorrenti
force-pushed
the
ignition-pkg
branch
from
ee74907 to
98f332d
Compare
|
/lgtm |
openshift-merge-bot
bot
merged commit 753bdc3
into
containers:main
91 of 92 checks passed
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all of the ignition files out of the
machinepackage and into its own calledignition. This requiredVMTypeto get moved out of themachinepackage and into thedefinepackage in order to prevent a circular dependency.Also uses the systemd parser UnitFile type to compose unit files instead of having hard-coded strings scattered around the files.
Does this PR introduce a user-facing change?