Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:BUILD] packit: handle builds for RC releases #20672

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Nov 13, 2023

The version_no_tilde rpm macro correctly handles both vX.Y.Z and vX.Y.Z-rcN git tags. Using this macro instead of version will soon allow Packit to handle RC builds correctly.

Accompanying change in Packit to land soon:
packit/packit#2149

Does this PR introduce a user-facing change?

None

Copy link
Contributor

openshift-ci bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2023
The `version_no_tilde` rpm macro correctly handles both `vX.Y.Z` and
`vX.Y.Z-rcN` git tags. Using this macro instead of `version` will soon
allow Packit to handle RC builds correctly.

Accompanying change in Packit to land soon:
packit/packit#2149

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 force-pushed the packit-pre-release branch from 3ad57eb to 6fa4a97 Compare November 13, 2023 12:08
@lsm5
Copy link
Member Author

lsm5 commented Nov 13, 2023

@cevich why does secret scan fail in https://github.com/lsm5/podman/actions/runs/6849732287/job/18622509799 but pass in the task list on the PR?

@lsm5
Copy link
Member Author

lsm5 commented Nov 13, 2023

@containers/podman-maintainers PTAL. This should be safe to merge.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Nov 13, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit c838a69 into containers:main Nov 13, 2023
43 of 44 checks passed
@lsm5 lsm5 deleted the packit-pre-release branch November 13, 2023 14:52
@cevich
Copy link
Member

cevich commented Nov 13, 2023

@lsm5 job shows:

12:08PM FTL unable to load gitleaks config, err: open /default/.gitleaks.toml: no such file or directory

That should not be possible, since the /default volume mount always comes from main. I see the job also died trying to send an alert-mail, which is also no good 😕

I'll add investigation of these into a "fix gitleaks" jira card I already have open.

@cevich
Copy link
Member

cevich commented Nov 13, 2023

Oh I figured it out! The key is very subtle in the job title:

[CI:BUILD] packit: handle builds for RC releases #7

That job ran against your personal fork of podman. You must have a main branch that's out of sync with the upstream main. This is completely broken though, that job should never run on forks.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Feb 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants