Consolidate XDG_RUNTIME code #20528
Merged
Consolidate XDG_RUNTIME code #20528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
giuseppe
force-pushed
the
consolidate-xdg-runtime-code
branch
from
f2ee640 to
c84727d
Compare
openshift-merge-robot
added
the
needs-rebase
|
Ephemeral COPR build failed. @containers/packit-build please check. |
giuseppe
force-pushed
the
consolidate-xdg-runtime-code
branch
from
c84727d to
d5f2e1e
Compare
openshift-merge-robot
removed
the
needs-rebase
giuseppe
force-pushed
the
consolidate-xdg-runtime-code
branch
10 times, most recently
from
b023d15 to
6908f8d
Compare
|
juts dropping this comment here that there is another runtime dir function in c/common: https://github.com/containers/common/blob/116177bb4c79804720002cb2402151a6cb005cc7/pkg/util/util_supported.go#L31 That should be replaced and tested as well, I tried in the past and it failed and got reverted: #13391. Of course as usual with no explaining as of why. |
openshift-merge-robot
added
the
needs-rebase
giuseppe
force-pushed
the
consolidate-xdg-runtime-code
branch
2 times, most recently
from
c171cbd to
5741726
Compare
openshift-merge-robot
removed
the
needs-rebase
giuseppe
force-pushed
the
consolidate-xdg-runtime-code
branch
2 times, most recently
from
f005d28 to
61dfac4
Compare
github-actions
bot
added
the
kind/api-change
giuseppe
force-pushed
the
consolidate-xdg-runtime-code
branch
from
61dfac4 to
587062b
Compare
github-actions
bot
removed
the
kind/api-change
giuseppe
force-pushed
the
consolidate-xdg-runtime-code
branch
from
587062b to
73b38e1
Compare
giuseppe
force-pushed
the
consolidate-xdg-runtime-code
branch
7 times, most recently
from
290a6c8 to
0c495e6
Compare
openshift-merge-robot
added
the
needs-rebase
giuseppe
force-pushed
the
consolidate-xdg-runtime-code
branch
from
0c495e6 to
3383313
Compare
openshift-merge-robot
removed
the
needs-rebase
giuseppe
force-pushed
the
consolidate-xdg-runtime-code
branch
from
3383313 to
b7bb3cc
Compare
openshift-merge-robot
added
the
needs-rebase
Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
consolidate-xdg-runtime-code
branch
from
b7bb3cc to
ffd1992
Compare
openshift-merge-robot
removed
the
needs-rebase
giuseppe
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
ready to merge! |
|
LGTM |
|
@flouthoc PTAL |
Luap99
reviewed
Nov 23, 2023
| @@ -1,6 +1,6 @@ | |||
| # /tmp/podman-run-* directory can contain content for Podman containers that have run | |||
| # for many days. This following line prevents systemd from removing this content. | |||
| x /tmp/podman-run-* | |||
There was a problem hiding this comment.
given podman stores the old tmpdir in the db and will keep using it AFAICT we should keep that old entry as well
[NO NEW TESTS NEEDED] no new functionalities are added Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
consolidate-xdg-runtime-code
branch
from
ffd1992 to
cd21973
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test for: containers/storage#1740
Does this PR introduce a user-facing change?