-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
windows: Use prebuilt gvproxy/win-sshproxy binaries #20202
Conversation
@n1hility @ashley-cui @baude PTAL |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than the minor issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to keep both targets in the .ps1 just in case a user wants to build gvproxy off main, or do you think that won't be a use case?
I don't think this will be needed very often/at all so I would not keep it. Easy to revert/rework if this turns out to be needed. Rebuilding one of these binaries from git can be done with a one-liner: |
Since gvisor-tap-vsock 0.7.1, the upstream project ships pre-built Windows binaries for gvproxy and win-sshproxy. These binaries are built with -Hwindowsgui as needed by podman. This makes the same change in winmake.ps1, but I had to hardcode gvisor-tap-vsock version in one more place. [NO NEW TESTS NEEDED] Signed-off-by: Christophe Fergeau <[email protected]>
LGTM |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, n1hility The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Since gvisor-tap-vsock 0.7.1, the upstream project ships pre-built
Windows binaries for gvproxy and win-sshproxy. These binaries are built
with -Hwindowsgui as needed by podman.
This makes the same change in winmake.ps1, but I had to hardcode
gvisor-tap-vsock version in one more place.
Does this PR introduce a user-facing change?