Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI:DOCS] Add podman farm build doc #20051

Merged
merged 1 commit into from
Nov 22, 2023
Merged

[CI:DOCS] Add podman farm build doc #20051

merged 1 commit into from
Nov 22, 2023

Conversation

umohnani8
Copy link
Member

Move the options for the podman build doc to a common md that can be used by both podman build and podman farm build.

Does this PR introduce a user-facing change?

Add podman farm build docs.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2023
@umohnani8 umohnani8 mentioned this pull request Sep 20, 2023
Merged
@umohnani8
Copy link
Member Author

/hold

Don't merge till #20050 is merged.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2023
@umohnani8 umohnani8 force-pushed the fbuild-doc branch 2 times, most recently from 9d44ca8 to 34c1df5 Compare September 20, 2023 14:35
@umohnani8
Copy link
Member Author

umohnani8 commented Sep 20, 2023 •
edited
Loading

How do I generate docs/source/markdown/podman-farm-build.1.md from docs/source/markdown/podman-farm-build.1.md.in?

Nvm, I think I figured it out. Added the podman-farm-build.1.md file.

@umohnani8 umohnani8 force-pushed the fbuild-doc branch 2 times, most recently from 6641916 to 6abb7e6 Compare September 20, 2023 16:34
@TomSweeneyRedHat
Copy link
Member

LGTM
Tests aren't hip at the moment though.

@umohnani8
Copy link
Member Author

Yeah, I think these will fail until #20050 gets in

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2023
@packit-as-a-service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2023
@rhatdan
Copy link
Member

rhatdan commented Nov 17, 2023

@umohnani8 Could you rebase and get this in?

@TomSweeneyRedHat
Copy link
Member

@umohnani8 yes, please do get this in as soon as you can. The QE team was looking for this last night. I've sent @ypu a note to this PR.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2023
@umohnani8
Copy link
Member Author

@TomSweeneyRedHat @rhatdan I was actually holding off on merging this till the farm rework is done. But if you feel it is better to merge this then we can go ahead and do that.

Updated and rebased.

@umohnani8
[CI:DOCS] Add podman farm build doc
414642e 
Move the options for the podman build doc to a common md
that can be used by both podman build and podman farm build.

Signed-off-by: Urvashi Mohnani <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Nov 22, 2023

This should only go into 5.0.

/lgtm
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit ca1331b into containers:main Nov 22, 2023
41 checks passed
@edsantiago edsantiago mentioned this pull request Nov 22, 2023
Merged
@TomSweeneyRedHat
Copy link
Member

@rhatdan This is in plan for Podman 4.8, RHEL 8.10/9.4. It is currently part of Buildah v1.33.0+ on Fedora, and Podman v4.8RC1. Cabal topic?

@rhatdan
Copy link
Member

rhatdan commented Nov 23, 2023

It missed the boat for 4.8. Should be in 5.0. More of a demonstration at this point. But it should be talked about.

edsantiago added a commit to edsantiago/libpod that referenced this pull request Nov 27, 2023
@edsantiago
Clean up farm-build miscommit
f6b2a13 
Followup to containers#20051, which I didn't review in time.

Signed-off-by: Ed Santiago <[email protected]>
mheon pushed a commit to mheon/libpod that referenced this pull request Jan 22, 2024
@edsantiago @mheon
Clean up farm-build miscommit
80be522 
Followup to containers#20051, which I didn't review in time.

Signed-off-by: Ed Santiago <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Feb 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flouthoc flouthoc flouthoc left review comments

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@umohnani8 @TomSweeneyRedHat @rhatdan @flouthoc @openshift-merge-robot