Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:BUILD] FCOS + podman-next image: pull in wasm #20041

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Sep 19, 2023

This commit installs crun-wasm and wasmedge-rt in the FCOS image at https://quay.io/repository/podman/fcos .

  • crun-wasm is installed from rhcontainerbot/podman-next
  • wasmedge-rt is installed from the official Fedora repos

Packages in Containerfile have also been rearranged in alphabetical order.

[NO NEW TESTS NEEDED]

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 19, 2023
@lsm5
Copy link
Member Author

lsm5 commented Sep 19, 2023

@cevich @benoitf @rhatdan PTAL

This commit installs `crun-wasm` and `wasmedge-rt` in the FCOS image at
https://quay.io/repository/podman/fcos .

- crun-wasm is installed from rhcontainerbot/podman-next
- wasmedge-rt is installed from the official Fedora repos

Packages in Containerfile have also been rearranged in alphabetical
order.

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Sep 19, 2023

LGTM

@benoitf
Copy link
Contributor

benoitf commented Sep 19, 2023

it's a good move but we still need crun-wasm and wasmedge-rt in default podman machines (here it requires a podman machine os apply and only 'next' releases of podman are available (not the tags)

@rhatdan
Copy link
Member

rhatdan commented Sep 19, 2023

We need to move to a podman-machine where this happens automatically.

@lsm5
Copy link
Member Author

lsm5 commented Sep 19, 2023

@benoitf @rhatdan sorry I'm gonna need some dumbing down to understand your comments. Machine terminology is quite unfamiliar to me.

@rhatdan
Copy link
Member

rhatdan commented Sep 19, 2023

rpm-ostree has a mechanism for updating from an OCI image like this. It would be nice to get to the point that we have a standard FCOS image set to point at an OCI Image with additional packages, and then install them as a layer on top of FCOS. They we would not need to beg from FCOS to add additional packages for Podman Machine.

@lsm5
Copy link
Member Author

lsm5 commented Sep 20, 2023

Given the recent fcos agreement, do we still need this even if temporarily? I'll need to repurpose this anyway to get crun-wasm from podman-next, even if it's just a symlink for now.

@rhatdan
Copy link
Member

rhatdan commented Sep 21, 2023

I think we need to work on the layering concept and complete it. I don't think we should be going to fcos any longer for additional packages. We need to get podman-machine to update from OCI Images like this one.

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Sep 21, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2023
@openshift-merge-robot openshift-merge-robot merged commit ada67a2 into containers:main Sep 21, 2023
@lsm5 lsm5 deleted the fcos-crun-wasm branch September 21, 2023 12:51
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Dec 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants