-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:BUILD] FCOS + podman-next image: pull in wasm #20041
Conversation
This commit installs `crun-wasm` and `wasmedge-rt` in the FCOS image at https://quay.io/repository/podman/fcos . - crun-wasm is installed from rhcontainerbot/podman-next - wasmedge-rt is installed from the official Fedora repos Packages in Containerfile have also been rearranged in alphabetical order. [NO NEW TESTS NEEDED] Signed-off-by: Lokesh Mandvekar <[email protected]>
fe51e9c
to
289be0c
Compare
LGTM |
it's a good move but we still need crun-wasm and wasmedge-rt in default podman machines (here it requires a podman machine os apply and only 'next' releases of podman are available (not the tags) |
We need to move to a podman-machine where this happens automatically. |
rpm-ostree has a mechanism for updating from an OCI image like this. It would be nice to get to the point that we have a standard FCOS image set to point at an OCI Image with additional packages, and then install them as a layer on top of FCOS. They we would not need to beg from FCOS to add additional packages for Podman Machine. |
Given the recent fcos agreement, do we still need this even if temporarily? I'll need to repurpose this anyway to get crun-wasm from podman-next, even if it's just a symlink for now. |
I think we need to work on the layering concept and complete it. I don't think we should be going to fcos any longer for additional packages. We need to get podman-machine to update from OCI Images like this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
This commit installs
crun-wasm
andwasmedge-rt
in the FCOS image at https://quay.io/repository/podman/fcos .Packages in Containerfile have also been rearranged in alphabetical order.
[NO NEW TESTS NEEDED]
Does this PR introduce a user-facing change?