systests: tighter checks for unwanted warnings #20036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note-none
approved
|
I love the trend of these PRs as of late @edsantiago . However, for this one, the CI is kicking up it's heals a bit. |
Part of RUN-1906. Followup to containers#19878 (check stderr in system tests): allow_warnings() and require_warning() functions to make sure no unexpected messages fall through the cracks. Signed-off-by: Ed Santiago <[email protected]>
edsantiago
force-pushed
the
bats_check_stderr
branch
from
95b5563 to
ff07abe
Compare
edsantiago
commented
Sep 19, 2023
Comment on lines
+81
to
+86
| # There are three different variations on the warnings, allow each... | ||
| allow_warnings "Failed to determine parent of image: .*, ignoring the error" \ | ||
| "Failed to determine if an image is a parent: .*, ignoring the error" \ | ||
| "Failed to determine if an image is a manifest list: .*, ignoring the error" | ||
| # ...but make sure we get at least one | ||
| require_warning "Failed to determine (parent|if an image is) .*, ignoring the error" |
There was a problem hiding this comment.
For those re-reviewing, this is what I had to fix & push
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of RUN-1906.
Followup to #19878 (check stderr in system tests): allow_warnings()
and require_warning() functions to make sure no unexpected messages
fall through the cracks.
Signed-off-by: Ed Santiago [email protected]