Merge pull request #23225 from edsantiago/no-more-ci-docs

pr-should-include-tests: no more CI:DOCS override
containers · Aug 12, 2024 · bd53a11 · bd53a11
2 parents 6738405 + 5e9ab00
commit bd53a11
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/contrib/cirrus/pr-should-include-tests b/contrib/cirrus/pr-should-include-tests
@@ -7,11 +7,6 @@ ME=$(basename $0)
 # Github label which allows overriding this check
 OVERRIDE_LABEL="No New Tests"
 
-# Docs-only changes are excused
-if [[ "${CIRRUS_CHANGE_TITLE}" =~ CI:DOCS ]]; then
-    exit 0
-fi
-
 # HEAD should be good enough, but the CIRRUS envariable allows us to test
 head=${CIRRUS_CHANGE_IN_REPO:-HEAD}
 # Base of this PR. Here we absolutely rely on cirrus.

diff --git a/contrib/cirrus/pr-should-include-tests.t b/contrib/cirrus/pr-should-include-tests.t
@@ -97,7 +97,7 @@ function run_test_script() {
             testnum=$(( testnum + 1 ))
 
             CIRRUS_CHANGE_TITLE="[CI:DOCS] hi there" $test_script &>/dev/null
-            if [[ $? -ne 0 ]]; then
+            if [[ $? -ne 1 ]]; then
                 echo "not ok $testnum $rest (override with CI:DOCS)"
                 rc=1
             else