fix remote build isolation on client side

Follow up to 493179b which only fixed the issue on the server despite me trying to fix it on the client as well, with this change here we always correctly unset the default on the remote client as the root/rootless status will be wrong. This means it is enough for users to either have a new server or client with the bug fix which should make the update process easier. Signed-off-by: Paul Holzinger <[email protected]>
containers · Mar 22, 2024 · 3a9968e · 3a9968e
1 parent aaa6dc3
commit 3a9968e
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/cmd/podman/common/build.go b/cmd/podman/common/build.go
@@ -113,6 +113,9 @@ func DefineBuildFlags(cmd *cobra.Command, buildOpts *BuildFlagsWrapper, isFarmBu
 	completion.CompleteCommandFlags(cmd, fromAndBudFlagsCompletions)
 	flags.SetNormalizeFunc(buildahCLI.AliasFlags)
 	if registry.IsRemote() {
+		// Unset the isolation default as we never want to send this over the API
+		// as it can be wrong (root vs rootless).
+		_ = flags.Lookup("isolation").Value.Set("")
 		_ = flags.MarkHidden("disable-content-trust")
 		_ = flags.MarkHidden("sign-by")
 		_ = flags.MarkHidden("signature-policy")