create machine dirs at discovery

in various use cases, the required machine dirs are not created. the machine dirs are runtimedir, datadir, and configdir. Example in Linux would be: configDir /<HOME>/.config/containers/podman/machine/<provider> dataDir /<HOME>/.local/share/containers/podman/machine/<provider> runtimeDir /run/user/1000/podman/machine now we blindly create them without checking for their existence (because it is faster). this fixes a bug where runtimedir does not exist on macos after a reboot [NO NEW TESTS NEEDED] Signed-off-by: Brent Baude <[email protected]>
containers · Feb 5, 2024 · 33bda05 · 33bda05
1 parent 268743a
commit 33bda05
Showing 1 changed file with 13 additions and 0 deletions.
diff --git a/pkg/machine/config.go b/pkg/machine/config.go
@@ -193,12 +193,25 @@ func GetMachineDirs(vmType define.VMType) (*define.MachineDirs, error) {
 	}
 
 	rtDirFile, err := define.NewMachineFile(rtDir, nil)
+	if err != nil {
+		return nil, err
+	}
 
 	dirs := define.MachineDirs{
 		ConfigDir:  configDirFile,
 		DataDir:    dataDirFile,
 		RuntimeDir: rtDirFile,
 	}
+
+	// make sure all machine dirs are present
+	if err := os.MkdirAll(rtDir, 0755); err != nil {
+		return nil, err
+	}
+	if err := os.MkdirAll(configDir, 0755); err != nil {
+		return nil, err
+	}
+	err = os.MkdirAll(dataDir, 0755)
+
 	return &dirs, err
 }