Skip to content

Commit

Permalink
Merge pull request #24403 from Luap99/tools-vendor
Browse files Browse the repository at this point in the history
go.mod vendor: ensure we never have the toolchain directive set
  • Loading branch information
openshift-merge-bot[bot] authored Nov 4, 2024
2 parents 63b577e + 0acd192 commit 2279a77
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 4 deletions.
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,7 @@ vendor:
$(GO) mod tidy
$(GO) mod vendor
$(GO) mod verify
$(GO) mod edit -toolchain none


# We define *-in-container targets for the following make targets. This allow the targets to be run in a container.
Expand Down
3 changes: 2 additions & 1 deletion contrib/cirrus/postbuild.sh
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ cd $CIRRUS_WORKING_DIR

# Note, make completions and make vendor will already be run in _run_build()
# so do not run them again for no reason. This just makes CI slower.
SUGGESTION="run 'make vendor' or 'make completions' and commit all changes" ./hack/tree_status.sh
showrun make -C test/tools vendor
SUGGESTION="run 'make vendor', 'make -C test/tools vendor' and 'make completions' and commit all changes" ./hack/tree_status.sh

showrun make .install.goimports
showrun make generate-bindings
Expand Down
3 changes: 2 additions & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
module github.com/containers/podman/v5

// Warning: Ensure the "go" and "toolchain" versions match exactly to prevent unwanted auto-updates
// Warning: if there is a "toolchain" directive anywhere in this file (and most of the
// time there shouldn't be), its version must be an exact match to the "go" directive.

go 1.22.6

Expand Down
1 change: 1 addition & 0 deletions test/tools/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ vendor:
$(GO) mod tidy
$(GO) mod vendor
$(GO) mod verify
$(GO) mod edit -toolchain none

.PHONY: clean
clean:
Expand Down
5 changes: 3 additions & 2 deletions test/tools/go.mod
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
module github.com/containers/podman/test/tools

go 1.22.0
// Warning: if there is a "toolchain" directive anywhere in this file (and most of the
// time there shouldn't be), its version must be an exact match to the "go" directive.

toolchain go1.22.7
go 1.22.0

require (
github.com/cpuguy83/go-md2man/v2 v2.0.5
Expand Down

1 comment on commit 2279a77

@packit-as-a-service
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

podman-next COPR build failed. @containers/packit-build please check.

Please sign in to comment.