Skip to content

Commit

Permalink
Merge pull request #22260 from baude/validatepr
Browse files Browse the repository at this point in the history
[CI:DOCS]Initial PR validation
  • Loading branch information
openshift-merge-bot[bot] authored Apr 11, 2024
2 parents 2f603fc + e773ed4 commit 0b03352
Show file tree
Hide file tree
Showing 3 changed files with 52 additions and 0 deletions.
12 changes: 12 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,18 @@ codespell:
.PHONY: validate
validate: lint .gitvalidation validate.completions man-page-check swagger-check tests-expect-exit pr-removes-fixed-skips

.PHONY: validatepr
validatepr:
$(PODMANCMD) run --rm --env HOME=/root \
-v $(CURDIR):/var/tmp/go/src/github.com/containers/podman \
--security-opt label=disable \
quay.io/libpod/fedora_podman:latest \
make .validatepr

.PHONY: .validatepr
.validatepr:
env BUILDTAGS="$(BUILDTAGS)" REMOTETAGS="$(REMOTETAGS)" contrib/validatepr/validatepr.sh

.PHONY: build-all-new-commits
build-all-new-commits:
# Validate that all the commits build on top of $(GIT_BASE_BRANCH)
Expand Down
17 changes: 17 additions & 0 deletions contrib/validatepr/Containerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
FROM registry.fedoraproject.org/fedora:latest

WORKDIR /go/src/github.com/containers/podman

RUN dnf install -y systemd-devel \
libassuan-devel \
libseccomp-devel \
gpgme-devel \
device-mapper-devel \
btrfs-progs-devel \
golang \
make \
man-db \
git \
perl-Clone \
perl-FindBin \
pre-commit && dnf clean all
23 changes: 23 additions & 0 deletions contrib/validatepr/validatepr.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
#!/bin/bash

set -x

#
# This script is intended to help developers contribute to the podman project. It
# checks various pre-CI checks like building, linting, man-pages, etc. It is meant
# to be run in a specific container environment.
#

# build all require incantations of podman
echo "Building windows ..."
GOOS=windows CGO_ENABLED=0 go build -tags "$REMOTETAGS" -o bin/test.windows ./cmd/podman
echo "Building darwin..."
GOOS=darwin CGO_ENABLED=0 go build -tags "$REMOTETAGS" -o bin/test.darwin ./cmd/podman

# build podman
echo "Building podman binaries ..."
make binaries


echo "Running validation tooling ..."
make validate

0 comments on commit 0b03352

Please sign in to comment.