Increase icon-size and font size of navbar contents #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cgiradkar could you post a picture of the change too please? The code LGTM, but I'm not 100% sure I'm looking at the right thing. |
|
Before: |
|
LGTM |
|
this looks awesome @cgiradkar! Is it possible to upscale the logotype
"podman" text as well?
~m
…On Wed, Oct 4, 2023 at 7:33 AM cgiradkar ***@***.***> wrote:
Before: [image: image]
<https://user-images.githubusercontent.com/135707592/272559724-9ea94b57-da9d-41ed-8ee6-cb5748a1a361.png>
After: [image: image]
<https://user-images.githubusercontent.com/135707592/272559789-c082643e-02aa-4003-b02d-34c60607f16e.png>
fyi @TomSweeneyRedHat <https://github.com/TomSweeneyRedHat> @mairin
<https://github.com/mairin>
—
Reply to this email directly, view it on GitHub
<#216 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGDHQZJR5EE7GULK3IVPYLX5VCQTAVCNFSM6AAAAAA5GPS27GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBWGY4TAMRZG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Signed-off-by: Chetan Giradkar <[email protected]>
cgiradkar
force-pushed
the
resize-navbar
branch
from
47694c4 to
1216d5b
Compare
I have increased font-size for "podman" text to xxx-large |
|
LGTM |
|
@mairin want to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chetan Giradkar [email protected]
closes #123