-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make 404 page more appealing. #207
Conversation
|
I like where this is going! |
LGTM |
Hey (sorry for the delay, I can give quicker feedback with screenshots, I don't always have access to the full env) I think this is great! I would just modify the text a bit:
I don't think many people are realistically going to contact the referrer (who may well be us) to report a broken link. Instead, can you offer them a way to search for the content they are looking for? Eg https://duckduckgo.com/?hps=1&q=site%3Apodman.io&atb=v299-1&ia=web Can you also refer to the link they tried to access that isn't available? If so I would rephrase like this (adding a bit of fun):
A few fun headers you could rotate between:
|
I like where this is going! |
5107585
to
9acc3c7
Compare
This is how it looks now: |
Love it, LGTM! |
@cgiradkar yes!!! just a couple nits and i think good to go:
Otherwise love it :) |
9acc3c7
to
933d132
Compare
Done, PTAL @mairin |
@cgiradkar maybe 5 px more? It's looking better! |
(also the url coloring looks perfect!) |
The 404 page was just having a plain old vanilla text. To revamp it, added a sad seal picture to signify the same. NotFound component was Swizzled via docusaurus and edited accordingly. Signed-off-by: Chetan Giradkar <[email protected]>
933d132
to
0732d71
Compare
perfect!! LGTM 👍🏻 |
LGTM |
The 404 page was just having a plain old vanilla text.
To revamp it, added a sad seal picture to signify the same.
NotFound component was Swizzled via docusaurus and edited accordingly.
closes #124
Signed-off-by: Chetan Giradkar <[email protected]>