Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 404 page more appealing. #207

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

cgiradkar
Copy link
Collaborator

@cgiradkar cgiradkar commented Sep 12, 2023

The 404 page was just having a plain old vanilla text.
To revamp it, added a sad seal picture to signify the same.
NotFound component was Swizzled via docusaurus and edited accordingly.

closes #124

Signed-off-by: Chetan Giradkar <[email protected]>

@cgiradkar cgiradkar mentioned this pull request Sep 12, 2023
@cgiradkar cgiradkar requested a review from mairin September 12, 2023 10:34
@cgiradkar
Copy link
Collaborator Author

  • To Swizzle a component: yarn swizzle @docusaurus/theme-classic NotFound --eject
  • To List Swizzle-able compoenents: yarn swizzle @docusaurus/theme-classic --list
  • Swizzle Docs

@TomSweeneyRedHat
Copy link
Member

I like where this is going!

@cgiradkar cgiradkar marked this pull request as ready for review September 19, 2023 09:27
@TomSweeneyRedHat
Copy link
Member

LGTM
but would like a looksee from @mairin

@mairin
Copy link
Member

mairin commented Sep 26, 2023

Hey (sorry for the delay, I can give quicker feedback with screenshots, I don't always have access to the full env)

Here is what I see:
Screenshot from 2023-09-26 07-20-07

I think this is great! I would just modify the text a bit:

Page Not Found

We could not find what you were looking for.

Please contact the owner of the site that linked you to the original URL and let them know their link is broken.

I don't think many people are realistically going to contact the referrer (who may well be us) to report a broken link. Instead, can you offer them a way to search for the content they are looking for? Eg

https://duckduckgo.com/?hps=1&q=site%3Apodman.io&atb=v299-1&ia=web

Can you also refer to the link they tried to access that isn't available?

If so I would rephrase like this (adding a bit of fun):

Oh no! We can't seal the deal!

We could not find what you were looking for: [podman.io/foo/bar](url) isn't a working link. The content may have moved; [try a search for it](url).

A few fun headers you could rotate between:

  • "Oh no! We can't seal the deal!"
  • "We can't seal with it!"
  • "This is seal-iously embarassing..."
  • "Seal-ly us! We can't find that page."
  • "Don't flip, but we can't find that."
  • "We don't sea that page."

@cgiradkar
Copy link
Collaborator Author

I like where this is going!

@cgiradkar cgiradkar force-pushed the Hotfix-124 branch 4 times, most recently from 5107585 to 9acc3c7 Compare September 27, 2023 16:37
@cgiradkar
Copy link
Collaborator Author

This is how it looks now:
localhost_3000_idontexist (2)
localhost_3000_idontexist (1)
localhost_3000_idontexist
@mairin FYI

@TomSweeneyRedHat
Copy link
Member

Love it, LGTM!

@mairin
Copy link
Member

mairin commented Sep 28, 2023

@cgiradkar yes!!! just a couple nits and i think good to go:

  • the header text needs a bit more margin-bottom or padding-bottom. like, maybe 5px additional to what it has now?

  • maaaaybe color the url that didn't resolve differently or use a fixed-width font or bold it? I would just bold it to be honest. But I'd like to see it stand out differently than the rest of the text.

Otherwise love it :)

@cgiradkar
Copy link
Collaborator Author

@cgiradkar yes!!! just a couple nits and i think good to go:

  • the header text needs a bit more margin-bottom or padding-bottom. like, maybe 5px additional to what it has now?
  • maaaaybe color the url that didn't resolve differently or use a fixed-width font or bold it? I would just bold it to be honest. But I'd like to see it stand out differently than the rest of the text.

Otherwise love it :)

Done, PTAL @mairin

@cgiradkar
Copy link
Collaborator Author

Screenshot after latest updates:
localhost_3000_idontexist (3)

@mairin
Copy link
Member

mairin commented Sep 29, 2023

@cgiradkar maybe 5 px more? It's looking better!

@mairin
Copy link
Member

mairin commented Sep 29, 2023

(also the url coloring looks perfect!)

The 404 page was just having a plain old vanilla text.
To revamp it, added a sad seal picture to signify the same.
NotFound component was Swizzled via docusaurus and edited accordingly.

Signed-off-by: Chetan Giradkar <[email protected]>
@cgiradkar
Copy link
Collaborator Author

padding-bottom: 1rem;
localhost_3000_idontexist (4)

@mairin
Copy link
Member

mairin commented Sep 29, 2023

perfect!! LGTM 👍🏻

@TomSweeneyRedHat
Copy link
Member

LGTM

@TomSweeneyRedHat TomSweeneyRedHat merged commit d952121 into containers:main Sep 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need better 404
3 participants