Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit workflow #473

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Conversation

inknos
Copy link
Contributor

@inknos inknos commented Nov 28, 2024

No description provided.

Copy link
Contributor

openshift-ci bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inknos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@inknos inknos mentioned this pull request Nov 28, 2024
18 tasks
@inknos inknos changed the title Pre commit ruff Add pre-commit workflow Nov 29, 2024
@inknos inknos force-pushed the pre-commit-ruff branch 2 times, most recently from 2d7edd9 to 826e081 Compare November 29, 2024 11:17
Signed-off-by: Nicola Sella <[email protected]>
@inknos
Copy link
Contributor Author

inknos commented Dec 4, 2024

@jwhonce would you like to take a look at this?

cc: @lsm5 as it introduces some cirrus, make and automation changes

@lsm5
Copy link
Member

lsm5 commented Dec 5, 2024

@inknos not opposed to cirrus, but just wondering if we can do without cirrus? Can we achieve the same via TMT by any chance?

@lsm5
Copy link
Member

lsm5 commented Dec 5, 2024

@inknos not opposed to cirrus, but just wondering if we can do without cirrus? Can we achieve the same via TMT by any chance?

I'm cool with dropping cirrus in a followup PR.

@jwhonce
Copy link
Member

jwhonce commented Dec 5, 2024

@inknos Please update https://github.com/containers/podman-py/blob/main/CONTRIBUTING.md to reflect the change of tools. Otherwise, looks good.

Signed-off-by: Nicola Sella <[email protected]>
@jwhonce
Copy link
Member

jwhonce commented Dec 9, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 16c0107 into containers:main Dec 9, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants