Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Podman API clarifies the field to give is
dns_option
, notdns_options
here, so we need to drop thes
to allowdns_opt
fields to properly populate.I thought about writing more unit tests for
containers_create.py
but there weren't existing tests for any of the options yet, so we'll have to add them for each API option I'd think.Test program:
Now properly works since we're passing in the right name:
Note that it looks like
tox
is failing for unrelated reasons; I'm hoping the CI will have different results and it's just a local problem.