Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include py.typed marker file. #381

Merged

Conversation

jonded94
Copy link
Contributor

I'm using this package in codebases checked with common static type checking tools, such as mypy. Unfortunately, it will error:

error: Skipping analyzing "podman": module is installed, but missing library stubs or py.typed marker  [import]

This was already apparent in #293. Including this file would at least enable checking against the many type hints that are already a part of this library and would help massively.

@jwhonce
Copy link
Member

jwhonce commented Mar 13, 2024

@jnsnow PTAL, TIA

@jonded94
Copy link
Contributor Author

jonded94 commented Apr 3, 2024

Any updates on this? This is only adding one single, entirely empty marker file; is this connected to any considerations?

@umohnani8
Copy link
Member

Thank you @jonded94! Can you please rebase with upstream and sign your commit and repush, I think that should help fix the DCO and gating failure.

Changes LGTM

@jonded94 jonded94 force-pushed the include-py-typed-marker branch 2 times, most recently from 39a4554 to 32fa6aa Compare April 5, 2024 10:18
@jonded94
Copy link
Contributor Author

jonded94 commented Apr 5, 2024

Did a rebase and a force repush, with a signed commit (which also shows to be verified in Github), but unfortunately that DCO job still fails?

@umohnani8
Copy link
Member

I believe DCO is failing because your commit doesn't have the Signed off by... line it. Can you please ensure git commit -s --amend adds that for you and then repush.

@jonded94 jonded94 force-pushed the include-py-typed-marker branch from 32fa6aa to 5f31809 Compare April 6, 2024 19:50
@jonded94
Copy link
Contributor Author

jonded94 commented Apr 6, 2024

Tests seem to run through now, thanks for your help!

@rhatdan
Copy link
Member

rhatdan commented Apr 8, 2024

/approve
/lgtm
Thanks @jonded94

Copy link
Contributor

openshift-ci bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonded94, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1aa8d90 into containers:main Apr 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants