Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated max_pools_size arg #375

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Remove deprecated max_pools_size arg #375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions podman/api/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ def __init__(
credstore_env: Optional[Mapping[str, str]] = None,
use_ssh_client=True,
max_pool_size=None,
max_pools_size=None, # This parameter is kept only for backward compatibility.
**kwargs,
): # pylint: disable=unused-argument
"""Instantiate APIClient object.
Expand All @@ -115,7 +114,6 @@ def __init__(
num_pools: The number of connection pools to cache.
credstore_env: Environment for storing credentials.
use_ssh_client: Use system ssh agent rather than ssh module. Always, True.
max_pools_size: Deprecated! Please use 'max_pool_size'.
max_pool_size: Override number of connections pools to maintain.
Default: requests.adapters.DEFAULT_POOLSIZE

Expand All @@ -135,21 +133,6 @@ def __init__(
# where the parameters are set specifically.
http_adapter_kwargs = {}

# 'max_pools_size' has been changed to 'max_pool_size'
# and the below section is needed for backward compatible.
# This section can be removed in a future release.
if max_pools_size is not None:
warnings.warn(
"'max_pools_size' parameter is deprecated! Please use 'max_pool_size' parameter.",
ParameterDeprecationWarning,
)
if max_pool_size is not None:
raise ValueError(
"Both of 'max_pools_size' and 'max_pool_size' parameters are set. "
"Please use only the 'max_pool_size', 'max_pools_size' is deprecated!"
)
max_pool_size = max_pools_size

if num_pools is not None:
adapter_kwargs["pool_connections"] = num_pools
http_adapter_kwargs["pool_connections"] = num_pools
Expand Down
Loading