Add workdir as alias for working_dir
#368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `podman-py` uses all three versions of `work_dir`, `working_dir` and `workdir` (not to mention `WorkingDir`). This commit tries to unify the parameter usage by allowing `workdir` for container `create` or `run`. For backwards compatibility `working_dir` still works. Since upstream Podman uses a variety of *workdir* versions the `podman-py` codebase can't be simplified further. Fix: containers#330 Signed-off-by: Paul Spooren <[email protected]> Signed-off-by: Urvashi Mohnani <[email protected]>
|
Replacing #332 |
|
What about the tests? |
|
@rhatdan no tests are needed, we are just adding an alias |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
/hold cancel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
podman-pyuses all three versions ofwork_dir,working_dirandworkdir(not to mentionWorkingDir).This commit tries to unify the parameter usage by allowing
workdirfor containercreateorrun. For backwards compatibilityworking_dirstill works.Since upstream Podman uses a variety of workdir versions the
podman-pycodebase can't be simplified further.Fix: #330