Make progress_bar an extra feature #361
Conversation
This allows the 'rich' dependency, which has additional dependencies and is not available in RHEL, to be optional. Fixes: containers#360 Signed-off-by: Yaakov Selkowitz <[email protected]>
yselkowitz
force-pushed
the
rich-optional
branch
from
b35c956 to
ea85c5f
Compare
|
/cc @umohnani8 |
|
LGTM. @umohnani8 @TomSweeneyRedHat it's either this or we end up moving python-rich from EPEL to RHEL proper and also own it long term which could be lot more work for us. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, yselkowitz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@umohnani8 I think we should get a new release out with this patch. |
|
Agree for the new release ASAP @lsm5 @yselkowitz this is brilliant, thank you! |
|
/cherry-pick release-4.8 |
|
@umohnani8: new pull request created: #362 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thanks for the fix @yselkowitz! |
|
Neat change @yselkowitz ! Thanks for running this down and putting it together. |
This allows the 'rich' dependency, which has additional dependencies and is not available in RHEL, to be optional.
Fixes: #360