Update pull progress bar colour #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Downloading bar is now in the default terminal text color and is bolded for better visibility. Bars will switch to green when completed. Signed-off-by: Urvashi Mohnani <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This is what the new output looks like |
|
LGTM thanks for your work |
|
Switching to bold is a good move: I tested with a colorblindness simulator, and it stands out under all models. It also looks much better to my eye. Plus, @baude's blessing carries a lot of weight. LGTM2. |
|
/lgtm |
|
Late, but looks better to me than the red/green prior. Nice work @umohnani8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Downloading bar is now in the default terminal text color and is bolded for better visibility.
Bars will switch to green when completed.